Caches for continuous benchmarking should be branch specific#805
Merged
lorenzwalthert merged 1 commit intor-lib:masterfrom May 26, 2021
Merged
Caches for continuous benchmarking should be branch specific#805lorenzwalthert merged 1 commit intor-lib:masterfrom
lorenzwalthert merged 1 commit intor-lib:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #805 +/- ##
=======================================
Coverage 90.46% 90.46%
=======================================
Files 47 47
Lines 2433 2433
=======================================
Hits 2201 2201
Misses 232 232 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
This is how benchmark results would change (along with a 95% confience interval in relative change) if 4e2d570 is merged into master:
Further explanation regarding interpretation and methodology can be found in the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise,
cache_applyingtakes long the first time to run (as the cache has to be built), and then is instant, but when you compute the average per branch, one will have the first run which will drastically increase the mean.