Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid adding braces to conditional expression in pipe #816

Merged
merged 2 commits into from Jun 30, 2021

Conversation

lorenzwalthert
Copy link
Collaborator

Closes #815.

…oken are added or removed, the rules account for token_after or token_before being potentially wrong. Don't think there is a case so far.
@lorenzwalthert lorenzwalthert changed the title avoid adding braces to conditional expression in pipe Avoid adding braces to conditional expression in pipe Jun 30, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #816 (588aa36) into master (14aebe0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 588aa36 differs from pull request most recent head 9a98927. Consider uploading reports for the commit 9a98927 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #816   +/-   ##
=======================================
  Coverage   90.45%   90.46%           
=======================================
  Files          47       47           
  Lines        2430     2432    +2     
=======================================
+ Hits         2198     2200    +2     
  Misses        232      232           
Impacted Files Coverage Δ
R/nest.R 100.00% <ø> (ø)
R/style-guides.R 99.39% <ø> (-0.01%) ⬇️
R/rules-indention.R 100.00% <100.00%> (ø)
R/rules-tokens.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14aebe0...9a98927. Read the comment docs.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confience interval in relative change) if 588aa36 is merged into master:

  • cache_applying: 0.12s -> 0.11s [-5.01%, +3.76%]
  • cache_recording: 1.51s -> 1.49s [-2.13%, 0%]
  • without_cache: 3.91s -> 3.79s [-3.67%, -2.37%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code within pipelines get broken
2 participants