Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set line break between %>% and { #825

Merged
merged 1 commit into from Jul 22, 2021

Conversation

lorenzwalthert
Copy link
Collaborator

@lorenzwalthert lorenzwalthert commented Jul 18, 2021

Closes #823. Would not resolve same structured code with other operators such as >, %in%, etc.

@codecov-commenter
Copy link

Codecov Report

Merging #825 (3cf05ea) into master (2e64b07) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #825   +/-   ##
=======================================
  Coverage   90.49%   90.49%           
=======================================
  Files          47       47           
  Lines        2441     2441           
=======================================
  Hits         2209     2209           
  Misses        232      232           
Impacted Files Coverage Δ
R/rules-line-breaks.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e64b07...3cf05ea. Read the comment docs.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confience interval in relative change) if 2d34499 is merged into master:

  • cache_applying: 0.1s -> 0.09s [-3.59%, +2.25%]
  • cache_recording: 1.31s -> 1.32s [-0.4%, +1.11%]
  • without_cache: 3.41s -> 3.41s [-1.17%, +1.31%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@lorenzwalthert
Copy link
Collaborator Author

Ok, let’s do it @MichaelChirico

@lorenzwalthert lorenzwalthert merged commit a8ec068 into r-lib:master Jul 22, 2021
@lorenzwalthert lorenzwalthert deleted the issue-823 branch July 22, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pipe-newline-brace inside call becomes pipe-brace-newline, violating pipe_continuation_linter
2 participants