Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non-parsable code in headers #832

Merged
merged 1 commit into from Aug 16, 2021

Conversation

lorenzwalthert
Copy link
Collaborator

Closes #831.

@codecov-commenter
Copy link

Codecov Report

Merging #832 (13e3523) into master (027d5b1) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 13e3523 differs from pull request most recent head 74b1f1f. Consider uploading reports for the commit 74b1f1f to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #832   +/-   ##
=======================================
  Coverage   90.53%   90.53%           
=======================================
  Files          47       47           
  Lines        2451     2451           
=======================================
  Hits         2219     2219           
  Misses        232      232           
Impacted Files Coverage Δ
R/transform-code.R 94.44% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 027d5b1...74b1f1f. Read the comment docs.

@lorenzwalthert lorenzwalthert merged commit 85f41ef into r-lib:master Aug 16, 2021
@lorenzwalthert lorenzwalthert deleted the issue-831 branch August 16, 2021 17:37
@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confience interval in relative change) if 13e3523 is merged into master:

  • cache_applying: 0.09s -> 0.03s [-69.75%, -62.97%]
  • cache_recording: 1.01s -> 0.99s [-2.36%, -1.48%]
  • without_cache: 2.56s -> 2.54s [-1.02%, -0.54%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restriction on R Markdown chunk names
2 participants