Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More advice for developers #861

Merged
merged 2 commits into from
Oct 29, 2021

Conversation

lorenzwalthert
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #861 (cc02090) into main (a84fd8d) will not change coverage.
The diff coverage is n/a.

❗ Current head cc02090 differs from pull request most recent head 77b96ed. Consider uploading reports for the commit 77b96ed to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #861   +/-   ##
=======================================
  Coverage   90.02%   90.02%           
=======================================
  Files          47       47           
  Lines        2486     2486           
=======================================
  Hits         2238     2238           
  Misses        248      248           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a84fd8d...77b96ed. Read the comment docs.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if cc02090 is merged into main:

  •   :ballot_box_with_check:cache_applying: 25.2ms -> 25.9ms [-2.48%, +8.75%]
  •   :ballot_box_with_check:cache_recording: 1.21s -> 1.18s [-8.25%, +3.05%]
  •   :ballot_box_with_check:without_cache: 2.71s -> 2.71s [-0.34%, +0.34%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@lorenzwalthert lorenzwalthert merged commit 8fa763a into r-lib:main Oct 29, 2021
@lorenzwalthert lorenzwalthert deleted the more-implementations branch October 29, 2021 13:22
@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if c1e6604 is merged into main:

  •   :ballot_box_with_check:cache_applying: 34.4ms -> 34.4ms [-2.25%, +2.39%]
  •   :ballot_box_with_check:cache_recording: 1.61s -> 1.62s [-0.27%, +1.21%]
  •   :ballot_box_with_check:without_cache: 4.24s -> 4.24s [-0.74%, +0.57%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@lorenzwalthert lorenzwalthert mentioned this pull request Mar 12, 2022
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants