Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make no trailing line a pre-processing step like trimming whitespaces #867

Merged
merged 2 commits into from
Nov 28, 2021

Conversation

lorenzwalthert
Copy link
Collaborator

@lorenzwalthert lorenzwalthert commented Nov 28, 2021

Not sure we can omit setting trailing whitespace now in hash_standardize -> cache_make_key() to speed things up a little bit. Closes #865.

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2021

Codecov Report

Merging #867 (9803e55) into main (9fa042a) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #867      +/-   ##
==========================================
- Coverage   89.73%   89.72%   -0.01%     
==========================================
  Files          47       47              
  Lines        2493     2492       -1     
==========================================
- Hits         2237     2236       -1     
  Misses        256      256              
Impacted Files Coverage Δ
R/utils-cache.R 100.00% <ø> (ø)
R/transform-files.R 97.01% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fa042a...9803e55. Read the comment docs.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if d24968d is merged into main:

  • ❗🐌cache_applying: 24.6ms -> 24.9ms [+0.46%, +2%]
  •   :rocket:cache_recording: 1.03s -> 1.02s [-1.94%, -0.42%]
  •   :ballot_box_with_check:without_cache: 2.71s -> 2.69s [-1.8%, +0.51%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@lorenzwalthert
Copy link
Collaborator Author

lorenzwalthert commented Nov 28, 2021

not probable that this introduces statistically significant speed gains, since it is from a theoretical point very surely making things worse! Or what am I missing?

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if eab7ee1 is merged into main:

  •   :ballot_box_with_check:cache_applying: 28.6ms -> 28.5ms [-1.16%, +0.74%]
  •   :ballot_box_with_check:cache_recording: 1.23s -> 1.21s [-4.09%, +0.41%]
  •   :ballot_box_with_check:without_cache: 3.08s -> 3.07s [-0.48%, +0.24%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@lorenzwalthert lorenzwalthert merged commit 6936ff7 into r-lib:main Nov 28, 2021
@lorenzwalthert lorenzwalthert deleted the issue-865 branch November 28, 2021 20:23
@lorenzwalthert lorenzwalthert mentioned this pull request Mar 12, 2022
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: remove trailing blank lines
2 participants