Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{glue} should not be a CRAN dependency #910

Merged
merged 2 commits into from
Feb 6, 2022

Conversation

lorenzwalthert
Copy link
Collaborator

Fixes CRAN Notes

@lorenzwalthert lorenzwalthert force-pushed the glue-suggests branch 2 times, most recently from 784b473 to 093ec10 Compare February 5, 2022 22:52
@codecov-commenter
Copy link

Codecov Report

Merging #910 (4ca9061) into main (9274aed) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #910   +/-   ##
=======================================
  Coverage   90.38%   90.38%           
=======================================
  Files          47       47           
  Lines        2559     2559           
=======================================
  Hits         2313     2313           
  Misses        246      246           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9274aed...4ca9061. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2022

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 5534d57 is merged into main:

  •   :ballot_box_with_check:cache_applying: 23.8ms -> 23.7ms [-0.67%, +0.16%]
  •   :ballot_box_with_check:cache_recording: 1.01s -> 1.01s [-0.44%, +0.31%]
  •   :ballot_box_with_check:without_cache: 2.7s -> 2.71s [-0.13%, +0.52%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@lorenzwalthert lorenzwalthert merged commit c43c99d into r-lib:main Feb 6, 2022
@lorenzwalthert lorenzwalthert deleted the glue-suggests branch February 6, 2022 13:08
@lorenzwalthert lorenzwalthert mentioned this pull request Mar 12, 2022
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants