Skip to content

Allow arbitrary indent characters for developers #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 18, 2022

Conversation

lorenzwalthert
Copy link
Collaborator

Closes #874

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 8f3c615 is merged into main:

  •   :ballot_box_with_check:cache_applying: 27.8ms -> 27.9ms [-2.94%, +3.48%]
  •   :ballot_box_with_check:cache_recording: 1.31s -> 1.3s [-2.45%, +0.91%]
  •   :ballot_box_with_check:without_cache: 3.46s -> 3.45s [-1.54%, +1.15%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if effc7d6 is merged into main:

  •   :ballot_box_with_check:cache_applying: 24.2ms -> 24.3ms [-0.19%, +1.06%]
  •   :ballot_box_with_check:cache_recording: 986ms -> 978ms [-3.24%, +1.61%]
  •   :ballot_box_with_check:without_cache: 2.72s -> 2.71s [-0.86%, +0.23%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@codecov-commenter
Copy link

Codecov Report

Merging #916 (e623d4b) into main (fd466c1) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #916      +/-   ##
==========================================
+ Coverage   90.38%   90.44%   +0.05%     
==========================================
  Files          47       47              
  Lines        2559     2574      +15     
==========================================
+ Hits         2313     2328      +15     
  Misses        246      246              
Impacted Files Coverage Δ
R/serialize.R 100.00% <100.00%> (ø)
R/style-guides.R 99.41% <100.00%> (+0.02%) ⬆️
R/testing.R 79.85% <100.00%> (+0.29%) ⬆️
R/transform-block.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd466c1...e623d4b. Read the comment docs.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 6777efa is merged into main:

  •   :ballot_box_with_check:cache_applying: 27.8ms -> 28.2ms [-2.3%, +5.36%]
  •   :ballot_box_with_check:cache_recording: 1.18s -> 1.18s [-0.8%, +1.35%]
  •   :ballot_box_with_check:without_cache: 3.13s -> 3.12s [-1.72%, +1.12%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@lorenzwalthert lorenzwalthert merged commit 004783a into r-lib:main Feb 18, 2022
@lorenzwalthert lorenzwalthert deleted the iussue-874 branch February 18, 2022 22:42
@lorenzwalthert lorenzwalthert mentioned this pull request Mar 12, 2022
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow tab indentation
2 participants