Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if = is on newline within function call, move key to same line #923

Merged
merged 2 commits into from
Mar 5, 2022

Conversation

lorenzwalthert
Copy link
Collaborator

@lorenzwalthert lorenzwalthert commented Mar 4, 2022

Closes #922.

call(a = b, x
     =2)

# becomes 
call(
  a = b,
  x = 2
)

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2022

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 3fa0b67 is merged into main:

  •   :rocket:cache_applying: 24.1ms -> 23.9ms [-1.34%, -0.28%]
  • ❗🐌cache_recording: 1.02s -> 1.04s [+1.71%, +2.36%]
  •   :ballot_box_with_check:without_cache: 2.74s -> 2.97s [-3%, +19.56%]

Further explanation regarding interpretation and methodology can be found in the documentation.

if on second line, move key also there
if on first line, leave it, might be intentional
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2022

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 1b78296 is merged into main:

  •   :ballot_box_with_check:cache_applying: 24.2ms -> 24.2ms [-1.09%, +0.68%]
  • ❗🐌cache_recording: 973ms -> 995ms [+1.95%, +2.74%]
  • ❗🐌without_cache: 2.62s -> 2.67s [+1.64%, +2.34%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@lorenzwalthert lorenzwalthert merged commit b9c4ffd into main Mar 5, 2022
@lorenzwalthert lorenzwalthert deleted the issue-922 branch March 5, 2022 21:03
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2022

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 46b67a8 is merged into main:

  •   :ballot_box_with_check:cache_applying: 24.2ms -> 24.2ms [-0.42%, +0.64%]
  •   :ballot_box_with_check:cache_recording: 1.04s -> 1.04s [-0.54%, +0.52%]
  •   :ballot_box_with_check:without_cache: 2.78s -> 2.78s [-0.67%, +0.54%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@lorenzwalthert lorenzwalthert mentioned this pull request Mar 12, 2022
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Surprising style when newline comes before =
1 participant