Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't check specific error message #929

Merged
merged 1 commit into from
Mar 12, 2022
Merged

Don't check specific error message #929

merged 1 commit into from
Mar 12, 2022

Conversation

lorenzwalthert
Copy link
Collaborator

Closes #925.

@codecov-commenter
Copy link

Codecov Report

Merging #929 (93eb4f8) into main (b70aebe) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #929   +/-   ##
=======================================
  Coverage   90.48%   90.48%           
=======================================
  Files          47       47           
  Lines        2585     2585           
=======================================
  Hits         2339     2339           
  Misses        246      246           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b70aebe...93eb4f8. Read the comment docs.

@lorenzwalthert lorenzwalthert merged commit afc969b into main Mar 12, 2022
@lorenzwalthert lorenzwalthert deleted the issue-925 branch March 12, 2022 23:51
@lorenzwalthert lorenzwalthert mentioned this pull request Mar 12, 2022
15 tasks
@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if e5955b1 is merged into main:

  •   :ballot_box_with_check:cache_applying: 23.7ms -> 23.7ms [-2.1%, +2.1%]
  •   :ballot_box_with_check:cache_recording: 1.02s -> 1.03s [-0.32%, +1.19%]
  •   :ballot_box_with_check:without_cache: 2.91s -> 2.94s [-1.82%, +3.37%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change in R devel causes different error message for _, making {styler} fail R CMD check
2 participants