Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused variables #999

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Remove unused variables #999

merged 1 commit into from
Sep 14, 2022

Conversation

IndrajeetPatil
Copy link
Collaborator

These are assigned but never used.

These are assigned but never used.
@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 3ed2964 is merged into main:

  •   :ballot_box_with_check:cache_applying: 28.3ms -> 28.2ms [-1.27%, +0.72%]
  •   :ballot_box_with_check:cache_recording: 1.33s -> 1.34s [-0.46%, +1.31%]
  •   :ballot_box_with_check:without_cache: 3.51s -> 3.5s [-0.63%, +0.25%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Copy link
Collaborator

@lorenzwalthert lorenzwalthert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@IndrajeetPatil IndrajeetPatil merged commit dbf8f29 into r-lib:main Sep 14, 2022
@IndrajeetPatil IndrajeetPatil deleted the rm_unused_variables branch September 14, 2022 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants