Skip to content

/ testthat

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expect_match and match don't report false on NULL object #100

Closed
hudon opened this issue Oct 28, 2013 · 2 comments
Closed

expect_match and match don't report false on NULL object #100

hudon opened this issue Oct 28, 2013 · 2 comments

Comments

@hudon
Copy link

@hudon hudon commented Oct 28, 2013 

> expect_match('a', 'oeu')
Error: "a" does not match 'oeu'. Actual value: 
a
> expect_match(NULL, 'oeu')
>

I would expect the second one to fail as well? Or is this intended?
@hadley
Copy link
Member

@hadley hadley commented Oct 29, 2013

That's definitely a bug.
@agstudy
Copy link

@agstudy agstudy commented Nov 6, 2013

related , but different behavior with 2 NULL:

expect_match(NULL, NULL)
Error: is.character(regexp) is not TRUE
@hadley hadley closed this in ef8dccc Dec 4, 2013
@jackwasey jackwasey mentioned this issue Apr 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@hadley @hudon @agstudy
You can’t perform that action at this time.