Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in setup code triggers silent failure #1004

Closed
gaborcsardi opened this issue Apr 2, 2020 · 0 comments · Fixed by #1067
Closed

Error in setup code triggers silent failure #1004

gaborcsardi opened this issue Apr 2, 2020 · 0 comments · Fixed by #1067
Labels
bug an unexpected problem or unintended behavior fixtures 🏭

Comments

@gaborcsardi
Copy link
Member

E.g.

setup(1+"a")
✔ |  OK F W S | Context
⠋ |   0 1     |
══ Results ═════════════════════════════════════════════════════════════════════
OK:       0
Failed:   1
Warnings: 0
Skipped:  0

Would be great to print that the setup code failed.

@hadley hadley added bug an unexpected problem or unintended behavior fixtures 🏭 labels Apr 13, 2020
hadley added a commit that referenced this issue Jun 29, 2020
Because that loses any information about earlier failures (either errors, or bare expectations). Fixes #1004.
hadley added a commit that referenced this issue Jun 30, 2020
Because that loses any information about earlier failures (either errors, or bare expectations). Required some re-engineering of the display to continue handling the manual contexts. Fixes #1004
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior fixtures 🏭
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants