Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only fail if no tests in 3e #1149

Closed
hadley opened this issue Aug 26, 2020 · 3 comments
Closed

Only fail if no tests in 3e #1149

hadley opened this issue Aug 26, 2020 · 3 comments

Comments

@hadley
Copy link
Member

hadley commented Aug 26, 2020

Since 2 of a random 100 revdeps failed with

      > test_package("pvar")
      Error: No tests found for pvar
      Execution halted
@hadley hadley transferred this issue from r-lib/pkgdown Aug 26, 2020
@hadley
Copy link
Member Author

hadley commented Aug 26, 2020

0 of 500 failed; so maybe not that common.

OTOH test_package() is probably associated with tests in the inst/tests which has been deprecated for a long time. OTOOH maybe it's not worth breaking any packages since the look up code is so simple? — which comes back to making an error for 3e, but not earlier.

@hadley
Copy link
Member Author

hadley commented Aug 27, 2020

This feature has been deprecated since 0.11.0 and it seems to be rare (2/600) so for now I'm going to close again.

@hadley hadley closed this as completed Aug 27, 2020
@hadley
Copy link
Member Author

hadley commented Aug 27, 2020

Figured out an easy way to do it, and seems worthwhile since these are old packages that will otherwise be sentenced to death.

@hadley hadley reopened this Aug 27, 2020
@hadley hadley closed this as completed in a4a15b6 Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant