Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify expext_snapshot_value() vs expect_snapshot_output()? #1649

Closed
maelle opened this issue Jun 27, 2022 · 0 comments · Fixed by #1682
Closed

Clarify expext_snapshot_value() vs expect_snapshot_output()? #1649

maelle opened this issue Jun 27, 2022 · 0 comments · Fixed by #1682
Labels
documentation snapshot 📷
Milestone
3.1.5

Comments

@maelle
Copy link
Contributor

maelle commented Jun 27, 2022

  • On https://testthat.r-lib.org/reference/expect_snapshot.html they could be explained together (rather than having two items between them).
  • I need to look up docs because "output" is what one can call the "return value" so maybe there could be a warning for users (in case my thinking isn't too weird).
@hadley hadley added this to the 3.1.5 milestone Sep 19, 2022
hadley added a commit that referenced this issue Sep 20, 2022
@hadley
Snapshot documentation improvements
900e002 
Fixes #1548. Fixes #1629. Fixes #1649.
@hadley hadley mentioned this issue Sep 20, 2022
Merged
hadley added a commit that referenced this issue Sep 22, 2022
@hadley
Snapshot documentation improvements (#1682)
1c9947d 
Fixes #1548. Fixes #1629. Fixes #1649.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation snapshot 📷
Projects
None yet
Milestone
3.1.5
Development

Successfully merging a pull request may close this issue.

Snapshot documentation improvements r-lib/testthat
2 participants
@hadley @maelle