expect_identical shouldn't always call all.equal() #165

wch · 2014-09-16T16:34:28Z

This happens now due to some changes in R-devel:

library(testthat)
e <- new.env()
class(e) <- "foo"
expect_identical(e, e)
# Error in as.vector(x, "list") : 
#   cannot coerce type 'environment' to vector of type 'list'

But it might get fixed in R-devel...

hadley · 2014-09-17T07:11:19Z

Hmmmm, this might need some fundamental changes to testthat - currently both the failure and success messages are generated regardless of which occurs.

hadley · 2014-09-17T07:15:29Z

Or I could just make the error message less informative.

wch · 2014-09-17T15:18:20Z

A less-informative error message seems fine to me.

hadley closed this as completed in b7b25b8 Sep 17, 2014

hadley reopened this Sep 17, 2014

hadley closed this as completed Sep 17, 2014

expect_identical shouldn't always call all.equal() #165

expect_identical shouldn't always call all.equal() #165

wch commented Sep 16, 2014

hadley commented Sep 17, 2014

hadley commented Sep 17, 2014

wch commented Sep 17, 2014

expect_identical shouldn't always call all.equal() #165

expect_identical shouldn't always call all.equal() #165

Comments

wch commented Sep 16, 2014

hadley commented Sep 17, 2014

hadley commented Sep 17, 2014

wch commented Sep 17, 2014