New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expect_silent() #261

Closed
hadley opened this Issue May 26, 2015 · 3 comments

Comments

Projects
None yet
3 participants
@hadley
Member

hadley commented May 26, 2015

i.e. no output, warnings, messages or errors.

@mmaechler

This comment has been minimized.

mmaechler commented Aug 11, 2015

I was looking for expect_no_message() and expect_no_warning() which are a bit more fine grained than just "silent". Also, I'd expect errors to trigger anyway, so there's no need to mention them here (or in the new functionality code).

@pitakakariki

This comment has been minimized.

pitakakariki commented Aug 28, 2015

I'd expect everything I test to be silent. I wonder if there's a way of implementing this that doesn't have nearly every test basically duplicated?

expect_equal(f(), 42)
expect_silent(f())
@hadley

This comment has been minimized.

Member

hadley commented Sep 28, 2015

I think would just test for absence of warnings, messages and output, since errors should be handled otherwise. Messages and output are usually ignored, and warnings will bubble up (once #254) is fixed.

@mmaechler this would be in addition to #219

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment