Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"F" and "E" labels swapped in MinimalReporter #311

Closed
richierocks opened this Issue Oct 17, 2015 · 0 comments

Comments

Projects
None yet
1 participant
@richierocks
Copy link

richierocks commented Oct 17, 2015

Using the minimal reporter, failing tests display an "E", and tests that throw an error display and "F". This seems to be the wrong way around to me, but I don't know if it's a genuine mistake or if I'm misunderstanding the output.

To reproduce, save this to a file:

test_that(
  "one is greater than zero",
  {
    expect_true(1 > 0)
  }
)
test_that(
  "one is less than zero",
  {
    expect_true(1 < 0)
  }
)
test_that(
  "this code runs",
  {
    stop("Oh no! An error!")
  }
)

Then run

test_file("test-file.R", reporter = "minimal")

I see the output .EF.

@hadley hadley closed this in a03d24b Feb 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.