Change wording in test_that output #36

Closed
kenahoo opened this Issue Mar 23, 2012 · 2 comments

Comments

Projects
None yet
2 participants
Contributor

kenahoo commented Mar 23, 2012

The syntax of the test_that() functions encourages users to write names for tests so that they have a natural kind of flow to the language:

test_that("forecast values match expected values", {
  ...
})

However, the output generated upon failure doesn't follow this same flow:

 Error: Test failure in 'forecast values match expected values'

Perhaps it could be changed to something more like this:

 Error: Testing whether 'forecast values match expected values'
Owner

hadley commented Mar 26, 2012

Good idea - I'll think about it.

Contributor

kenahoo commented Mar 26, 2012

To ease the work I committed this in my fork: kenahoo/test_that@734ad97 . But I couldn't figure out how to issue a pull request for just one cherry-picked commit. Must be missing something in the interface.

@hadley hadley closed this in 7695167 Mar 20, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment