New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should empty test_that throw a skip? #413

Closed
hadley opened this Issue Mar 17, 2016 · 1 comment

Comments

Projects
None yet
3 participants
@hadley
Member

hadley commented Mar 17, 2016

So it's easy to notice when you've forgotten to add an expectations

@gaborcsardi

This comment has been minimized.

Member

gaborcsardi commented Mar 17, 2016

I used to put code in test_that without any expectations, just to make sure that it runs. This was before expect_silent(). Sometimes I put in an expect_true(TRUE) at the end, just to see some output, sometimes not.

Anyway, a skip is not an error, just a mild message, and I agree it could be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment