Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default environment for source_test_helpers() #415

Closed
jennybc opened this issue Mar 17, 2016 · 1 comment
Closed

default environment for source_test_helpers() #415

jennybc opened this issue Mar 17, 2016 · 1 comment

Comments

@jennybc
Copy link
Member

@jennybc jennybc commented Mar 17, 2016

The default environment for source_test_helpers() changed from the global environment to the test environment. This is noticeable when I step through test files interactively. Unless I do source_test_helpers(..., env = globalenv()), nothing I define in my helper files is actually available.

I liked the old way better, but maybe there are good reasons for the change? In which case, this would be good to put into NEWS.md.

@hadley hadley closed this in 791f6de Mar 22, 2016
@hadley
Copy link
Member

@hadley hadley commented Mar 22, 2016

The point was to make it consistent with the other source_*() functions. But I now think your problem should be resolved by devtools - could you please file an issue there? (if you haven't already)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants