Skip to content

/ testthat

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix expect_output_file() on Windows #510

Closed
krlmlr opened this issue Jul 29, 2016 · 2 comments
Closed

Fix expect_output_file() on Windows #510

krlmlr opened this issue Jul 29, 2016 · 2 comments
Labels
expectation 🙀 feature
Milestone
1.1.0

Comments

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Jul 29, 2016

Need to read and write as UTF-8 with LF (krlmlr/enc#8).
@krlmlr krlmlr mentioned this issue Jul 30, 2016
Closed
@hadley hadley added the feature label Dec 15, 2016
@hadley
Copy link
Member

@hadley hadley commented Dec 15, 2016

Is there any easy fix for this?
@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Dec 15, 2016

By now we have read_lines_with_encoding() in this package. We also need a better writing function w.r.t. encoding and line separator. I wonder if the utf8 package is a better place for these functions; I might be able to release utf8 just in time.
@hadley hadley modified the milestone: 1.1.0 Dec 16, 2016
@hadley hadley closed this in e23e7c4 Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
expectation 🙀 feature
Projects
None yet
Milestone
1.1.0
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@hadley @krlmlr