New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expect_output_file() on Windows #510

Closed
krlmlr opened this Issue Jul 29, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@krlmlr
Member

krlmlr commented Jul 29, 2016

Need to read and write as UTF-8 with LF (krlmlr/enc#8).

@hadley

This comment has been minimized.

Member

hadley commented Dec 15, 2016

Is there any easy fix for this?

@hadley hadley added the expectation label Dec 15, 2016

@krlmlr

This comment has been minimized.

Member

krlmlr commented Dec 15, 2016

By now we have read_lines_with_encoding() in this package. We also need a better writing function w.r.t. encoding and line separator. I wonder if the utf8 package is a better place for these functions; I might be able to release utf8 just in time.

@hadley hadley modified the milestone: 1.1.0 Dec 16, 2016

@hadley hadley closed this in e23e7c4 Oct 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment