Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to stop tests earlier if more than n fail #520

Closed
hadley opened this issue Sep 1, 2016 · 7 comments
Closed

Option to stop tests earlier if more than n fail #520

hadley opened this issue Sep 1, 2016 · 7 comments
Milestone

Comments

@hadley
Copy link
Member

@hadley hadley commented Sep 1, 2016

Because it typically indicates something is seriously wrong, and you just want to see the errors right away.

@hadley
Copy link
Member Author

@hadley hadley commented Dec 15, 2016

@krlmlr how do you feel about this being the default behaviour? i.e. if there are > getOption("testthat.summary.max_reports", 15L) we terminate reporter early?

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Dec 19, 2016

Now included in #502.

@hadley
Copy link
Member Author

@hadley hadley commented Dec 19, 2016

This is mildly tricky as we need a new subclass of stop that will immediately terminate execution of the entire test suite, and not get captured like usual errors.

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Dec 19, 2016

Could you please check if hadley@de82b5b would also work?

@hadley
Copy link
Member Author

@hadley hadley commented Dec 19, 2016

I wrote my comment on the plane a couple of days ago when I didn't have internet access and only just submitted it. I think your approach is fine.

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Dec 19, 2016

Offline comments? Intriguing. (Or was it just an open browser tab? ;-) )

@hadley
Copy link
Member Author

@hadley hadley commented Dec 19, 2016

Open browser tab ;)

@hadley hadley closed this in #502 Dec 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.