Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Reporter that prints the location of all expectations #551

Closed
krlmlr opened this issue Dec 11, 2016 · 5 comments
Closed

FR: Reporter that prints the location of all expectations #551

krlmlr opened this issue Dec 11, 2016 · 5 comments
Milestone

Comments

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Dec 11, 2016

Useful to locate test code that triggers a particular line of C++ or R code.

@hadley
Copy link
Member

@hadley hadley commented Dec 15, 2016

You're thinking of this when you get a segfault in the tests and want to quickly narrow down the code that causes it?

@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Dec 15, 2016

This, and also if I just set a breakpoint in C++ code and want to find the code that triggers it.

@hadley hadley modified the milestone: 1.1.0 Dec 16, 2016
@hadley hadley closed this in 49e68d1 Dec 16, 2016
@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Dec 18, 2016

Awesome, thanks!

@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Jan 27, 2017

@hadley: Just used it for the first time, works as advertised. I've noticed two things:

  • The reporter prints absolute paths on my system, is this intended?
  • It would be helpful if it also printed the locations of each test_that() call (entry and exit)
@hadley
Copy link
Member

@hadley hadley commented Jan 27, 2017

Probably not - I'd be happy to review a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.