New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Reporter that prints the location of all expectations #551

Closed
krlmlr opened this Issue Dec 11, 2016 · 5 comments

Comments

Projects
None yet
2 participants
@krlmlr
Member

krlmlr commented Dec 11, 2016

Useful to locate test code that triggers a particular line of C++ or R code.

@hadley

This comment has been minimized.

Member

hadley commented Dec 15, 2016

You're thinking of this when you get a segfault in the tests and want to quickly narrow down the code that causes it?

@krlmlr

This comment has been minimized.

Member

krlmlr commented Dec 15, 2016

This, and also if I just set a breakpoint in C++ code and want to find the code that triggers it.

@hadley hadley modified the milestone: 1.1.0 Dec 16, 2016

@hadley hadley closed this in 49e68d1 Dec 16, 2016

@krlmlr

This comment has been minimized.

Member

krlmlr commented Dec 18, 2016

Awesome, thanks!

@krlmlr

This comment has been minimized.

Member

krlmlr commented Jan 27, 2017

@hadley: Just used it for the first time, works as advertised. I've noticed two things:

  • The reporter prints absolute paths on my system, is this intended?
  • It would be helpful if it also printed the locations of each test_that() call (entry and exit)
@hadley

This comment has been minimized.

Member

hadley commented Jan 27, 2017

Probably not - I'd be happy to review a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment