Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unset R_TESTS #603

Closed
gaborcsardi opened this issue Jun 20, 2017 · 9 comments
Closed

Unset R_TESTS #603

gaborcsardi opened this issue Jun 20, 2017 · 9 comments
Labels

Comments

@gaborcsardi
Copy link
Contributor

@gaborcsardi gaborcsardi commented Jun 20, 2017

It only causes trouble, it is not actually doing anything useful.

@hadley
Copy link
Member

@hadley hadley commented Oct 2, 2017

Always, or just in test_check()?

@hadley hadley added the feature label Oct 2, 2017
@gaborcsardi
Copy link
Contributor Author

@gaborcsardi gaborcsardi commented Oct 2, 2017

why not always? to have consistent behavior?.

@hadley
Copy link
Member

@hadley hadley commented Oct 2, 2017

Ok, sure thing.

@hadley hadley closed this in 902c876 Oct 4, 2017
@wlandau-lilly
Copy link

@wlandau-lilly wlandau-lilly commented Oct 17, 2017

Will this affect #86? I am preparing drake for the upcoming testthat 2.0.0, and I rely on tests executed in subdirectories of tempdir().

@gaborcsardi
Copy link
Contributor Author

@gaborcsardi gaborcsardi commented Oct 17, 2017

Yes, it fixes #86.

@wlandau-lilly
Copy link

@wlandau-lilly wlandau-lilly commented Oct 17, 2017

Perfect!

@hughjonesd
Copy link

@hughjonesd hughjonesd commented Dec 16, 2017

I used to use the presence of R_TESTS to skip certain tests which don't play well with R CMD check. Is there an alternative? I'm aware of skip_on_cran and friends.

@gaborcsardi
Copy link
Contributor Author

@gaborcsardi gaborcsardi commented Dec 16, 2017

@hughjonesd you can set an environment variable in tests/testthat.R. This only runs for R CMD check.

@hughjonesd
Copy link

@hughjonesd hughjonesd commented Dec 16, 2017

Got it. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.