Failed tests don't print in the progress section, but appear in the results #705
Labels
Comments
|
I wonder if it's related to having two contexts in https://github.com/njtierney/naniar/blob/master/tests/testthat/test-replace-with-na.R. It's possible there's a bug related to multiple contexts in one file. |
|
Do you still have the problem with a different reporter? |
|
Ooop - sorry, I thought I wrote more about this - I didn't specify |
|
marking this as a bug, as we should still be reporting test failures even if there is no context (by having a default context). |
jimhester
added a commit
to jimhester/testthat
that referenced
this issue
Apr 2, 2018
Test files without an explicit `context()` would cause
Error in x[[method]](...) : attempt to apply non-function
errors in the Progress reporter and a different (unreported) error in
the JUnit reporter. This generates a context from the filename if there
is not already a defined context, fixing the issue.
Fixes r-lib#700
Fixes r-lib#705
jimhester
added a commit
that referenced
this issue
Apr 4, 2018
Test files without an explicit `context()` would cause
Error in x[[method]](...) : attempt to apply non-function
errors in the Progress reporter and a different (unreported) error in
the JUnit reporter. This generates a context from the filename if there
is not already a defined context, fixing the issue.
Fixes #700
Fixes #705
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi there!
At this commit of naniar I get the following print message when I run devtools::test()
(apologies for hard coding the pkg PATH in the reprex, I couldn't get it to work otherwise!
The problem is that it doesn't print that I have 5 tests that failed, but shows me that I have 5 tests that failed.
When I run
devtools::check()I can identify that the tests all fail in test-replace-with-na-where.Perhaps I've missed something obvious, but thought you might like to know about this,
Thanks again for building and maintaining a package I use every day!
Session info
The text was updated successfully, but these errors were encountered: