Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle keyboard interruption better? #727

Closed
gaborcsardi opened this issue Mar 8, 2018 · 1 comment
Closed

Handle keyboard interruption better? #727

gaborcsardi opened this issue Mar 8, 2018 · 1 comment
Labels
feature a feature request or enhancement reporter 📝

Comments

@gaborcsardi
Copy link
Member

Maybe. Right now, I sometimes just get normal output, e.g.:

Loading pkgdepends
Testing pkgdepends
✔ | OK F W S | Context
✔ | 116       | assertions [0.1 s]
⠴ |  6       | async utils^C

══ Results ═════════════════════════════════════════════════════════════════════
Duration: 0.5 s

OK:       122
Failed:   0
Warnings: 0
Skipped:  0

Keep up the good work.
@jimhester jimhester added the feature a feature request or enhancement label Mar 29, 2018
@hadley
Copy link
Member

hadley commented Apr 18, 2018

Should also handle parsing failures in the same way:

Error in parse(textConnection(lines, encoding = "UTF-8"), n = -1, srcfile = srcfile,  : 
  /Users/hadley/Documents/r-dbi/bigrquery/tests/testthat/test-dbi-connection.R:95:57: unexpected '{'
94: 
95: test_that("can create bq_table from connection + name") {
                                                            ^
Calls: <Anonymous> ... FUN -> with_reporter -> force -> source_file -> parse
In addition: Warning message:
package ‘testthat’ was built under R version 3.4.3 
══ Results ═════════════════════════════════════════════════════════════════════════════
Duration: 56.0 s

OK:       113
Failed:   0
Warnings: 0
Skipped:  0
Execution halted

@hadley hadley added this to the testthat 2.1.0 milestone Apr 1, 2019
@hadley hadley closed this as completed in 422b08b Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement reporter 📝
Projects
None yet
Development

No branches or pull requests

3 participants