Skip to content

/testthat

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export_error should warn if text match but class exists #816

Closed
hadley opened this issue Nov 13, 2018 · 2 comments

Comments

Assignees
No one assigned
Labels
expectation 🙀 feature
Projects
None yet
Milestone
  testthat 2.1.0
2 participants
@hadley @gaborcsardi
@hadley
Copy link
Member

commented Nov 13, 2018

If you call expect_error(error_with_class(), "text") testthat should warn that it's better to use class.

@hadley hadley referenced this issue Dec 8, 2018

Merged

Add error conditions #598

@hadley hadley added feature expectation 🙀 labels Mar 28, 2019

@hadley hadley added this to the testthat 2.1.0 milestone Apr 1, 2019

@hadley hadley closed this in 9fb8875 Apr 1, 2019

@gaborcsardi

This comment has been minimized.

Sign in to view
Copy link
Member

commented Apr 1, 2019

Hmmm, this will cause some damage I am afraid. But we'll see in the revdep checks....
@hadley

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Apr 1, 2019

It only generates a warning in the tests which doesn't affect R CMD check, so it should be ok.

richfitz added a commit to mrc-ide/odin that referenced this issue May 8, 2019

@richfitz
Update tests to cope with testthat behaviour change 
Change introduced in
r-lib/testthat#816

requires update to ~200 tests as warnings make identification of
test failures almost impossible.
Loading status checks…
27a7601

@richfitz richfitz referenced this issue May 9, 2019

Merged

Adjust test to examine error-condition #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.