Skip to content

/ testthat Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export_error should warn if text match but class exists #816

Closed
hadley opened this issue Nov 13, 2018 · 2 comments
Closed

export_error should warn if text match but class exists #816

hadley opened this issue Nov 13, 2018 · 2 comments
Labels
expectation 🙀 feature
Milestone
testthat 2.1.0

Comments

@hadley
Copy link
Member

@hadley hadley commented Nov 13, 2018

If you call expect_error(error_with_class(), "text") testthat should warn that it's better to use class.
@hadley hadley mentioned this issue Dec 8, 2018
Merged
@hadley hadley added this to the testthat 2.1.0 milestone Apr 1, 2019
@hadley hadley closed this in 9fb8875 Apr 1, 2019
@gaborcsardi
Copy link
Contributor

@gaborcsardi gaborcsardi commented Apr 1, 2019

Hmmm, this will cause some damage I am afraid. But we'll see in the revdep checks....

@hadley
Copy link
Member Author

@hadley hadley commented Apr 1, 2019

It only generates a warning in the tests which doesn't affect R CMD check, so it should be ok.

richfitz added a commit to mrc-ide/odin that referenced this issue May 8, 2019
@richfitz
Update tests to cope with testthat behaviour change
Loading status checks…
27a7601 
Change introduced in
r-lib/testthat#816

requires update to ~200 tests as warnings make identification of
test failures almost impossible.
@richfitz richfitz mentioned this issue May 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
expectation 🙀 feature
Projects
None yet
Milestone
testthat 2.1.0
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@hadley @gaborcsardi