Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak default messages for skip_if, skip_if_not #868

Closed
kevinushey opened this issue Apr 19, 2019 · 2 comments
Closed

tweak default messages for skip_if, skip_if_not #868

kevinushey opened this issue Apr 19, 2019 · 2 comments

Comments

@kevinushey
Copy link
Collaborator

@kevinushey kevinushey commented Apr 19, 2019

E.g.

> skip_if_not(FALSE)
Error: FALSE

It'd be nice if this showed something more like Error: FALSE is not TRUE or something with slightly more text.

As an example, the reported skip condition in devtools::test() is something like:

test-file.R:33: skip: we can do the thing
check_thing()

It would be a little more descriptive to instead write something like:

test-file.R:33: skip: we can do the thing
check_thing() is not TRUE
@hadley
Copy link
Member

@hadley hadley commented Apr 23, 2019

Yeah, agreed. Want to do a PR?

Loading

@hadley
Copy link
Member

@hadley hadley commented Apr 23, 2019

test-unnest.R:93: skip: unnesting zero row column preserves names
empty

Should be:

test-unnest.R:93: skipped: unnesting zero row column preserves names
Reason: empty

Loading

@hadley hadley added the wip label Jul 16, 2019
@hadley hadley closed this in #876 Jul 16, 2019
hadley added a commit that referenced this issue Jul 16, 2019
Includes fixed to get reporter tests running again.

Fixes #868
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants