-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Begin revamp of CheckReporter #1075
Conversation
Conflicts: R/reporter-check.R
Conflicts: R/expectation.R tests/testthat/reporters/check.txt tests/testthat/reporters/summary-no-dots.txt tests/testthat/reporters/summary.txt tests/testthat/test-expect-condition.txt tests/testthat/test-expect-messages-warning.txt
And use the same format as rlang/C compilers.
@gaborcsardi sorry the diff got a bit big/messy. I think the main things to look are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is actually much simpler than I expected.
Fixes #1073