Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Begin revamp of CheckReporter #1075

Merged
merged 18 commits into from
Jul 7, 2020
Merged

Begin revamp of CheckReporter #1075

merged 18 commits into from
Jul 7, 2020

Conversation

hadley
Copy link
Member

@hadley hadley commented Jun 30, 2020 •
edited
Loading

Fixes #1073

hadley added 15 commits June 30, 2020 17:46
@hadley
Begin revamp of CheckReporter
36f1b8c
@hadley
Restore skip and failure summaries
7f1001e
@hadley
Only show test starts on CI
e8deaf2
@hadley
Merge remote-tracking branch 'refs/remotes/origin/master'
3162b82 
Conflicts:
	R/reporter-check.R
@hadley
Need to figure out why this is getting run in a different scope
d60dae1
@hadley
Merge remote-tracking branch 'refs/remotes/origin/master'
058cc36 
Conflicts:
	R/expectation.R
	tests/testthat/reporters/check.txt
	tests/testthat/reporters/summary-no-dots.txt
	tests/testthat/reporters/summary.txt
	tests/testthat/test-expect-condition.txt
	tests/testthat/test-expect-messages-warning.txt
@hadley
Style check reporter output
a7b5885
@hadley
Eliminate fragile test
2027e9d
@hadley
Update docs
ce03170
@hadley
Display warnings in CheckReporter
1976afe
@hadley
Capture all problems and report on them
9d6f229
@hadley
Remove uneeded fields
c0a47ea
@hadley
Standardise display expectation location
26f9a12 
And use the same format as rlang/C compilers.
@hadley
Save rds of all failures
6a693a7
@hadley
Add NEWS bullet
203fd3c
@hadley hadley marked this pull request as ready for review July 7, 2020 12:35
@hadley hadley requested a review from gaborcsardi July 7, 2020 12:35
@hadley
Copy link
Member Author

hadley commented Jul 7, 2020 •
edited
Loading

@gaborcsardi sorry the diff got a bit big/messy. I think the main things to look are CheckReporter and the bottom of `check.txt. The rest is mostly just a standardisation of the way we reporter error locations, which apparently had ~4 variations 😬

@hadley hadley closed this Jul 7, 2020
@hadley hadley deleted the check-info branch July 7, 2020 13:00
@hadley hadley restored the check-info branch July 7, 2020 14:09
@hadley hadley reopened this Jul 7, 2020
gaborcsardi
gaborcsardi approved these changes Jul 7, 2020
View reviewed changes
Copy link
Member

@gaborcsardi gaborcsardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is actually much simpler than I expected.

@hadley hadley closed this Jul 7, 2020
@hadley hadley deleted the check-info branch July 7, 2020 16:53
@hadley hadley restored the check-info branch July 7, 2020 19:30
@hadley hadley reopened this Jul 7, 2020
@hadley hadley merged commit 06af82c into master Jul 7, 2020
@hadley hadley deleted the check-info branch July 7, 2020 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborcsardi gaborcsardi gaborcsardi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improvements to CheckReporter
2 participants
@hadley @gaborcsardi