Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add expect_no_match() #1381

Merged
merged 4 commits into from May 21, 2021
Merged

add expect_no_match() #1381

merged 4 commits into from May 21, 2021

Conversation

michaelquinn32
Copy link
Contributor

Fixes #1380

@michaelquinn32
Copy link
Contributor Author

@MichaelChirico Let me know if this lines up with what you were thinking re grep() and grepl()

@MichaelChirico
Copy link
Contributor

Yep that's what I had in mind, thanks!

@hadley
Copy link
Member

hadley commented May 18, 2021

I’d prefer to not use grep() and keep the change minimal so I don’t need to review the source code of grepl/grep to ensure there aren’t any unhappy surprises. .

@MichaelChirico
Copy link
Contributor

FWIW I looked into why grepl doesn't have an invert argument recently and know their sources are very tightly coupled...

but fair point -- I will try and put the backend to grep() in a different PR if so desired

@michaelquinn32
Copy link
Contributor Author

SGTM. Thanks for the feedback Hadley!

Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a bullet to the top of NEWS.md? It should briefly describe the change and end with (@yourname, #issuenumber).

@michaelquinn32
Copy link
Contributor Author

Friendly ping!

Is there anything else that I can do here?

@hadley hadley merged commit b0b3319 into r-lib:master May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add expect_no_match
3 participants