Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snapshot_review() in the hint of snapshots #1500

Closed
wants to merge 2 commits into from
Closed

Add snapshot_review() in the hint of snapshots #1500

wants to merge 2 commits into from

Conversation

DanChaltiel
Copy link

Hi,

Copypasting the Run snapshot_accept("my_file") if this is a deliberate change hint to the console is a game-changer when using snapshots!

However, one does not often blindly accept changes, so snapshot_review() seems more adapted, at least to my use.

Not sure about the grammar though (I never know when "change" should be plural in English).

Copypasting the hint to the console is a game changer! However, one does not often blindly accept changes so `snapshot_review()` seems more adapted, at least to my use.
@hadley
Copy link
Member

hadley commented Dec 14, 2021

But don't you already see the differences interactively? (and in git, should the interactive display not be sufficient?)

@DanChaltiel
Copy link
Author

I'm not sure what you mean.

In RStudio, when I hit "Ctrl+Shift+T", it runs all the tests in the "Build" panel.
If several snapshots changed (which can happen a lot in my case), the output can be messy and ends with Run snapshot_accept("my_file") if this is a deliberate change, which I copy-paste to the console and change to snapshot_review("my_file").

This build output is very useful but far less readable than snapshot_review() (no colors, no vertical dual-view...).

Using GitHub desktop software is nice but since the new output will be named differently ("_new" IIRC), there will not be any difference highlighting.

@hadley hadley added this to the v3.1.2 milestone Jan 5, 2022
@hadley
Copy link
Member

hadley commented Jan 5, 2022

Needs to wait on #1531

hadley added a commit that referenced this pull request Jan 6, 2022
@hadley hadley closed this in #1537 Jan 6, 2022
hadley added a commit that referenced this pull request Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants