Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add skipped message to JUnit Reporter #1507

Merged
merged 5 commits into from
Jan 4, 2022
Merged

add skipped message to JUnit Reporter #1507

merged 5 commits into from
Jan 4, 2022

Conversation

rfineman
Copy link
Contributor

@rfineman rfineman commented Dec 3, 2021

Added the skipped test message to output when using JunitReporter.

@hadley
Copy link
Member

hadley commented Dec 14, 2021

@rfineman did you run this on windows? It looks like the line endings in the snapshot test got messed up, which is probably a testthat buglet.

@rfineman
Copy link
Contributor Author

@hadley yeah ran on windows. apologies if that bugged out the snapshot

@hadley
Copy link
Member

hadley commented Dec 14, 2021

It's definitely my fault, not yours!

@hadley hadley merged commit f3eca01 into r-lib:main Jan 4, 2022
@hadley
Copy link
Member

hadley commented Jan 4, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants