Allow test_path() to work in helper files #1760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisVaughan
approved these changes
Mar 30, 2023
| file.path(...) | ||
| } | ||
| base <- NULL | ||
| } else if (pkgload::is_loading()) { |
Member
There was a problem hiding this comment.
Should you supply the name of the package being tested as pkg here?
Member
Author
There was a problem hiding this comment.
I don't think it's necessary, since it'll be pretty rare that multiple are being loaded at the same time.
R/test-path.R
Outdated
|
|
||
| if (!dir.exists(base)) { | ||
| abort("Can't find `tests/testthat/` in current directory.") | ||
| cli::cli_abort("Can find {.path {base}}.") |
Member
There was a problem hiding this comment.
Another example of r-lib/cli#587 where we show a .path fragment that doesn't actually exist, but it will seem clickable.
Co-authored-by: Davis Vaughan <davis@rstudio.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And generally improve code, tests, and docs. Closes #1756. Fixes #1562.