Skip to content

Conversation

@hadley
Copy link
Member

@hadley hadley commented Sep 29, 2025

No description provided.

@claude
Copy link

claude bot commented Sep 29, 2025

Claude finished @hadley's task —— View job


PR Review: Correctly test inputs in expect_setequal()

  • Read and analyze the changed files
  • Review the code changes for potential bugs or issues
  • Provide concise feedback

Analysis of changes:

  • Fixed check_vector() calls in expect_setequal() to validate act$val and exp$val instead of object and expected
  • Added proper error_arg parameters for better error messages
  • Added test cases for unquoted expressions using !!fun syntax
  • Generated corresponding snapshot tests

Review:
The fix correctly addresses the issue where expect_setequal() was validating the wrong objects. Previously it validated object and expected (the expressions), but should validate act$val and exp$val (the actual values). This ensures proper type checking and error reporting.

LGTM.

@hadley hadley merged commit 325995d into main Sep 29, 2025
13 checks passed
@hadley hadley deleted the setequal-bang-bang branch September 29, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants