Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Handle skipped tests in TAP reporter #262
I'd happily write a test for this change if you could indicate where that should be. I didn't find any tests for the reporter output, only for the existence of reporters. I did confirm that the output with the skip directives is correctly parsed, at least by the Jenkins TAP parser:
Ok, tests for the TAP reporter output added, including a test for the skip directive. This should increase test coverage, though the coveralls job in https://travis-ci.org/hadley/testthat/builds/64178838 timed out (which appears to be why the Travis build was marked as failing; the tests passed).
referenced this pull request
Jul 9, 2015
Looks like the NEWS bullet I added was clobbered in a merge: nealrichardson/testthat@master...hadley:masterdiff-8312ad0561ef661716b48d09478362f3L10
I could make a new PR with that if you want, but maybe it's easier for you to just add it back.