Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support shorthand syntax reporter1+reporter2+... #307

Merged
merged 11 commits into from Feb 19, 2016
Merged

Conversation

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Oct 4, 2015

for creating a multi-reporter that reports to reporter1, reporter2 and the others.

Now find_reporter("") throws an error.

Use case: devtools::test(reporter = "summary+stop") in a Makefile.

@hadley: I'm not sure which of the two below is the better syntax:

devtools::test(reporter = "summary+stop")
devtools::test(reporter = c("summary", "stop"))

I could also support both. I still need to add documentation and NEWS, please let me know what you think before I proceed.

for creating a multi-reporter that reports to reporter1, reporter2 and the others.

Now `find_reporter("")` throws an error.

Use case: `devtools::test(reporter = "summary+stop")` in a Makefile.
@krlmlr krlmlr mentioned this pull request Nov 10, 2015
@hadley
Copy link
Member

@hadley hadley commented Feb 18, 2016

I'd prefer a character vector.

@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Feb 18, 2016

Now supporting both character vector and "+" notation.

@hadley
Copy link
Member

@hadley hadley commented Feb 18, 2016

Unless you have a strong preference, I'd prefer to just have the character vector version.

@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Feb 18, 2016

Removed support for "+" notation.

@hadley
Copy link
Member

@hadley hadley commented Feb 19, 2016

LGTM - feel free to news it & merge.

krlmlr added a commit that referenced this pull request Feb 19, 2016
- `find_reporter()` (and also all high-level testing functions) support a vector of reporters. For more than one reporter, a `MultiReporter` is created (#307, @krlmlr).
@krlmlr krlmlr merged commit 1f43dc0 into r-lib:master Feb 19, 2016
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@krlmlr krlmlr deleted the krlmlr:find-multi branch Feb 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants