New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throws_error(NA) has unexpected behavior #317

Merged
merged 9 commits into from Feb 18, 2016

Conversation

Projects
None yet
3 participants
@krlmlr
Member

krlmlr commented Nov 7, 2015

  • with regexp=NA and an actual error thrown
  • failure message with successful code and expected error

Also affects expect_error(..., NA).

Solved by adapting implementation to that of gives_warning().

Kirill Müller added some commits Nov 7, 2015

Kirill Müller
adapt throws_error() implementation to gives_warnings()
for consistency, and to resolve issues
@hadley

This comment has been minimized.

Member

hadley commented Nov 9, 2015

Looks good. Can you add a bullet to NEWS please?

@krlmlr

This comment has been minimized.

Member

krlmlr commented Nov 9, 2015

Done.

Kirill Müller added some commits Nov 9, 2015

@krlmlr

This comment has been minimized.

Member

krlmlr commented Nov 10, 2015

Moved bullet up.

@famuvie

This comment has been minimized.

famuvie commented Nov 16, 2015

Neat solution, indeed!

Kirill Müller added some commits Nov 16, 2015

Kirill Müller
Kirill Müller
Merge branch 'master' into throws-error-fix
Overriding changes of #342, because they were already implemented here (albeit differently).
@krlmlr

This comment has been minimized.

Member

krlmlr commented Feb 18, 2016

Merged with master.

@hadley hadley merged commit 8ac83d7 into r-lib:master Feb 18, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment