Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throws_error(NA) has unexpected behavior #317

Merged
merged 9 commits into from Feb 18, 2016

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Nov 7, 2015

  • with regexp=NA and an actual error thrown
  • failure message with successful code and expected error

Also affects expect_error(..., NA).

Solved by adapting implementation to that of gives_warning().

Kirill Müller added 2 commits November 7, 2015 21:58
@hadley
Copy link
Member

hadley commented Nov 9, 2015

Looks good. Can you add a bullet to NEWS please?

@krlmlr
Copy link
Member Author

krlmlr commented Nov 9, 2015

Done.

@krlmlr
Copy link
Member Author

krlmlr commented Nov 10, 2015

Moved bullet up.

@famuvie
Copy link

famuvie commented Nov 16, 2015

Neat solution, indeed!

@krlmlr
Copy link
Member Author

krlmlr commented Feb 18, 2016

Merged with master.

@hadley hadley merged commit 8ac83d7 into r-lib:master Feb 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants