Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throws_error(NA) has unexpected behavior #317

Merged
merged 9 commits into from Feb 18, 2016
Merged

Conversation

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Nov 7, 2015

  • with regexp=NA and an actual error thrown
  • failure message with successful code and expected error

Also affects expect_error(..., NA).

Solved by adapting implementation to that of gives_warning().

Kirill Müller added 2 commits Nov 7, 2015
@hadley
Copy link
Member

@hadley hadley commented Nov 9, 2015

Looks good. Can you add a bullet to NEWS please?

@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Nov 9, 2015

Done.

@krlmlr krlmlr force-pushed the krlmlr:throws-error-fix branch from ce63f83 to 785b5b9 Nov 9, 2015
@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Nov 10, 2015

Moved bullet up.

@famuvie
Copy link

@famuvie famuvie commented Nov 16, 2015

Neat solution, indeed!

@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Feb 18, 2016

Merged with master.

@hadley hadley merged commit 8ac83d7 into r-lib:master Feb 18, 2016
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants