New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New expect_output_file() #443

Merged
merged 9 commits into from Apr 18, 2016

Conversation

Projects
None yet
2 participants
@krlmlr
Member

krlmlr commented Apr 9, 2016

Compares output against file contents, and optionally updates it.

With test, and using it already in this package.

I'm not really happy with the name, any suggestions?

Kirill Müller added some commits Apr 9, 2016

Kirill Müller
dogfood expect_output_file()
now updating golden files in case of failure
Kirill Müller
Kirill Müller
@krlmlr

This comment has been minimized.

Member

krlmlr commented Apr 18, 2016

I've been using this in some projects already, works for me (and for testthat). Any chance to include it in the upcoming point release, perhaps marked as "experimental"?

@hadley

This comment has been minimized.

Member

hadley commented Apr 18, 2016

I think so - can you add a bullet to NEWS and I'll merge

Kirill Müller added some commits Apr 18, 2016

@krlmlr

This comment has been minimized.

Member

krlmlr commented Apr 18, 2016

Done, Travis test ok.

@hadley hadley merged commit 66ac1a4 into r-lib:master Apr 18, 2016

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hadley

This comment has been minimized.

Member

hadley commented Apr 18, 2016

Thanks!

@krlmlr krlmlr deleted the krlmlr:feature/expect-output-file branch May 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment