Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New expect_output_file() #443

Merged
merged 9 commits into from Apr 18, 2016
Merged

New expect_output_file() #443

merged 9 commits into from Apr 18, 2016

Conversation

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Apr 9, 2016

Compares output against file contents, and optionally updates it.

With test, and using it already in this package.

I'm not really happy with the name, any suggestions?

@krlmlr krlmlr force-pushed the krlmlr:feature/expect-output-file branch from 47272e3 to bcb9fd3 Apr 9, 2016
@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Apr 18, 2016

I've been using this in some projects already, works for me (and for testthat). Any chance to include it in the upcoming point release, perhaps marked as "experimental"?

@hadley
Copy link
Member

@hadley hadley commented Apr 18, 2016

I think so - can you add a bullet to NEWS and I'll merge

@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Apr 18, 2016

Done, Travis test ok.

@hadley hadley merged commit 66ac1a4 into r-lib:master Apr 18, 2016
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hadley
Copy link
Member

@hadley hadley commented Apr 18, 2016

Thanks!

@krlmlr krlmlr deleted the krlmlr:feature/expect-output-file branch May 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants