Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit fmt argument with safe default to difference() #446

Merged
merged 2 commits into from Apr 18, 2016

Conversation

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Apr 9, 2016

Fixes #445.

NEWS entry:

- Hardened formatting of difference messages, previously the presence of % characters could affect the output (#446, @krlmlr).
@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Apr 9, 2016

I have added a GITHUB_PAT to Travis to avoid build errors.

@krlmlr krlmlr force-pushed the krlmlr:feature/445-sanitize-sprintf branch from 3c127e6 to b80c637 Apr 16, 2016
@hadley hadley merged commit b80c637 into r-lib:master Apr 18, 2016
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@krlmlr krlmlr deleted the krlmlr:feature/445-sanitize-sprintf branch May 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants