New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New DebugReporter #470

Merged
merged 27 commits into from Jul 5, 2016

Conversation

Projects
None yet
3 participants
@krlmlr
Member

krlmlr commented May 7, 2016

Calls a better version of recover() that shows only the interesting part of the call stack. Fully tested.

Fixes #360.

Kirill Müller added some commits Mar 8, 2016

Kirill Müller
only divert if sink active
sink(stdout()) behaves strangely if no sink is active
Kirill Müller
limit stack frame shown in debug reporter
- also fix off-by-one error in original implementation of recover()
- also ignore options that turn recover() behavior off
Kirill Müller
also test browser entry points
- mock browse_frame() which is called from our recover()
- record the frame that would have been used for the browser() call
- list variables defined in that frame, compare with expectation
@codecov-io

This comment has been minimized.

codecov-io commented Jun 2, 2016

Current coverage is 50.98%

Merging #470 into master will decrease coverage by 31.82%

@@             master       #470   diff @@
==========================================
  Files            45         46     +1   
  Lines          1360       1379    +19   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           1126        703   -423   
- Misses          234        676   +442   
  Partials          0          0          

Powered by Codecov. Last updated by 728cac2...80477e1

)
)
# Copied from utils::recover()

This comment has been minimized.

@hadley

hadley Jul 3, 2016

Member

Can you please also copy the copyright statement? It might be better to move into completely a new file. Will also need to update Authors@R to reference R core

@krlmlr krlmlr referenced this pull request Jul 4, 2016

Merged

Report endless recursion #474

Kirill Müller added some commits Jul 4, 2016

@krlmlr krlmlr added this to the 1.0.3 milestone Jul 4, 2016

@krlmlr krlmlr added this to the 1.0.3 milestone Jul 4, 2016

@hadley

This comment has been minimized.

Member

hadley commented Jul 5, 2016

LGTM

Kirill Müller added some commits Jul 5, 2016

@krlmlr krlmlr merged commit c73954f into r-lib:master Jul 5, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@krlmlr krlmlr deleted the krlmlr:feature/debug-reporter branch Jul 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment