Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New DebugReporter #470

Merged
merged 27 commits into from Jul 5, 2016
Merged

New DebugReporter #470

merged 27 commits into from Jul 5, 2016

Conversation

@krlmlr
Copy link
Member

@krlmlr krlmlr commented May 7, 2016

Calls a better version of recover() that shows only the interesting part of the call stack. Fully tested.

Fixes #360.

Kirill Müller added 12 commits Mar 8, 2016
sink(stdout()) behaves strangely if no sink is active
- also fix off-by-one error in original implementation of recover()
- also ignore options that turn recover() behavior off
- mock browse_frame() which is called from our recover()
- record the frame that would have been used for the browser() call
- list variables defined in that frame, compare with expectation
@codecov-io
Copy link

@codecov-io codecov-io commented Jun 2, 2016

Current coverage is 50.98%

Merging #470 into master will decrease coverage by 31.82%

@@             master       #470   diff @@
==========================================
  Files            45         46     +1   
  Lines          1360       1379    +19   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           1126        703   -423   
- Misses          234        676   +442   
  Partials          0          0          

Powered by Codecov. Last updated by 728cac2...80477e1

)
)

# Copied from utils::recover()

This comment has been minimized.

@hadley

hadley Jul 3, 2016
Member

Can you please also copy the copyright statement? It might be better to move into completely a new file. Will also need to update Authors@R to reference R core

@krlmlr krlmlr mentioned this pull request Jul 4, 2016
@krlmlr krlmlr force-pushed the krlmlr:feature/debug-reporter branch 2 times, most recently from fc47b5a to c2881c3 Jul 4, 2016
@krlmlr krlmlr force-pushed the krlmlr:feature/debug-reporter branch from c2881c3 to 7c79e9d Jul 4, 2016
@krlmlr krlmlr modified the milestone: 1.0.3 Jul 4, 2016
@hadley
Copy link
Member

@hadley hadley commented Jul 5, 2016

LGTM

@krlmlr krlmlr merged commit c73954f into r-lib:master Jul 5, 2016
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@krlmlr krlmlr deleted the krlmlr:feature/debug-reporter branch Jul 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants