Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Junit reporter #481
I've rewritten the JUnit reporter to match the new API. I understand xml2 and its own tests are missing, I'll work on that in the coming days. In the meantime, could you please let me know if there is anything missing/flawed as far as JUnit/testthat designs go?
I want to integrate testthat with JUnit/XML output but I'm not a JUnit expert.
Current coverage is 79.88% (diff: 100%)
@@ master #481 diff @@ ========================================== Files 56 57 +1 Lines 1668 1735 +67 Methods 0 0 Messages 0 0 Branches 0 0 ========================================== + Hits 1311 1386 +75 + Misses 357 349 -8 Partials 0 0
I've merged but I'm not sure if that's enough to "clean up the commit history". Can you elaborate what exactly would be your goal? I could copy the current diff into a new branch and that way you'd have a single commit with no history there - but I thought you would rather keep track of all actual contributors.
I've also added a few lines to
You have 37 commits which seems rather a lot but if you don't want to squash the commits, I'll simply do it when I merge it.
I agree that you should be outputting the xml, not the summary reporter results.
Almost there. Just a few little things left.
I think redirecting the output to the right place is outside the scope of testthat. I think usually some other process will be calling R, and it will take care of saving the output to the right place.