New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report bare expectations #498

Merged
merged 14 commits into from Feb 20, 2017

Conversation

Projects
None yet
3 participants
@krlmlr
Member

krlmlr commented Jul 4, 2016

This makes sure that all testing code is run in a reporter and with the usual testthat condition handling. Fixes #427.

CC @kevinushey.

@krlmlr krlmlr modified the milestone: 1.0.3 Jul 4, 2016

@kevinushey

This comment has been minimized.

Collaborator

kevinushey commented Jul 4, 2016

Nice!

I wonder if the wrap argument is really needed? It'd be nice (IMO) if that could be the default behavior, but I'm assuming you backed it out because of failing tests / other complications?

@krlmlr

This comment has been minimized.

Member

krlmlr commented Jul 5, 2016

We must not wrap the helpers, but perhaps we can make wrap = TRUE the default.

@krlmlr

This comment has been minimized.

Member

krlmlr commented Jul 6, 2016

Second take, now with wrap = TRUE by default and all tests passing.

@krlmlr krlmlr changed the title from Sketch for reporting bare expectations to Report bare expectations Jul 6, 2016

@kevinushey

This comment has been minimized.

Collaborator

kevinushey commented Jul 6, 2016

🎉

@hadley

This comment has been minimized.

Member

hadley commented Dec 15, 2016

LGTM. Could you please merge/rebase?

@krlmlr

This comment has been minimized.

Member

krlmlr commented Dec 18, 2016

@hadley: Rebased, adapted. Documentation isn't in Markdown yet (#559). Travis failure is related to codoc errors which will be fixed after running document().

@krlmlr

This comment has been minimized.

Member

krlmlr commented Dec 19, 2016

Using Markdown now.

@hadley

This comment has been minimized.

Member

hadley commented Dec 29, 2016

Is this good to merge?

@krlmlr

This comment has been minimized.

Member

krlmlr commented Dec 30, 2016

I think so.

@krlmlr krlmlr merged commit 37cc0d0 into r-lib:master Feb 20, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@krlmlr krlmlr deleted the krlmlr:feature/report-bare branch Feb 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment