Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report bare expectations #498

Merged
merged 14 commits into from
Feb 20, 2017
Merged

Report bare expectations #498

merged 14 commits into from
Feb 20, 2017

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Jul 4, 2016 •
edited
Loading

This makes sure that all testing code is run in a reporter and with the usual testthat condition handling. Fixes #427.

CC @kevinushey.

@krlmlr krlmlr modified the milestone: 1.0.3 Jul 4, 2016
@kevinushey
Copy link
Collaborator

Nice!

I wonder if the wrap argument is really needed? It'd be nice (IMO) if that could be the default behavior, but I'm assuming you backed it out because of failing tests / other complications?

@krlmlr
Copy link
Member Author

krlmlr commented Jul 5, 2016

We must not wrap the helpers, but perhaps we can make wrap = TRUE the default.

@krlmlr
Copy link
Member Author

krlmlr commented Jul 6, 2016

Second take, now with wrap = TRUE by default and all tests passing.

@krlmlr krlmlr changed the title Sketch for reporting bare expectations Report bare expectations Jul 6, 2016
@kevinushey
Copy link
Collaborator

🎉

@hadley
Copy link
Member

hadley commented Dec 15, 2016

LGTM. Could you please merge/rebase?

@krlmlr
Copy link
Member Author

krlmlr commented Dec 18, 2016 •
edited
Loading

@hadley: Rebased, adapted. Documentation isn't in Markdown yet (#559). Travis failure is related to codoc errors which will be fixed after running document().

@krlmlr
Copy link
Member Author

krlmlr commented Dec 19, 2016

Using Markdown now.

@hadley
Copy link
Member

hadley commented Dec 29, 2016

Is this good to merge?

@krlmlr
Copy link
Member Author

krlmlr commented Dec 30, 2016

I think so.

@krlmlr krlmlr merged commit 37cc0d0 into r-lib:master Feb 20, 2017
@krlmlr krlmlr deleted the feature/report-bare branch February 20, 2017 15:53
@brodieG brodieG mentioned this pull request Sep 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@krlmlr @kevinushey @hadley