Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape regular expression characters in error output. #522

Closed
wants to merge 1 commit into from

Conversation

@jimhester
Copy link
Member

@jimhester jimhester commented Sep 3, 2016

This should make it more clear why something that looks identical did
not match.

e.g. expect_match("foo() is not bar", "foo() is not bar")

This should make it more clear why something that looks identical did
not match.

e.g. expect_match("foo() is not bar", "foo() is not bar")
@jimhester jimhester force-pushed the jimhester:escape_regex_output branch from 903e38e to a767738 Sep 3, 2016
@hadley
Copy link
Member

@hadley hadley commented Dec 15, 2016

This is good to merge. I'll merge when I'm next at my computer so I can resolve the news conflict

@hadley
Copy link
Member

@hadley hadley commented Dec 15, 2016

Closed by 1483f35. Not sure why it didn't automatically close

@hadley hadley closed this Dec 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants