New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow base packages to be mocked #553

Merged
merged 10 commits into from Oct 3, 2017

Conversation

Projects
None yet
2 participants
@hadley
Member

hadley commented Dec 15, 2016

Fixes #546

@krlmlr I'm going to need your help to figure out how to modify the tests that rely on mocking base packages.

@krlmlr

This comment has been minimized.

Member

krlmlr commented Dec 15, 2016

I'll take a look and update the branch.

@hadley

This comment has been minimized.

Member

hadley commented Oct 2, 2017

@krlmlr could you please take a look again?

@krlmlr

This comment has been minimized.

Member

krlmlr commented Oct 2, 2017

I think we decided that we just can't mock base packages. I'll remove/update these tests, but I also need to refactor package code. When would be a good time to do this, to avoid conflicts?

@hadley

This comment has been minimized.

Member

hadley commented Oct 2, 2017

What code do you need to touch? I'm at a conference so I'm just knocking off smaller issues.

@krlmlr

This comment has been minimized.

Member

krlmlr commented Oct 3, 2017

Turned out it's just a few places.

@krlmlr

This comment has been minimized.

Member

krlmlr commented Oct 3, 2017

Why can't I request a review from you on this PR?

@hadley

This comment has been minimized.

Member

hadley commented Oct 3, 2017

I think it's because it's my PR originally?

@hadley

Just needs a NEWS bullet.

(And I apparently I can't approve my own PR either)

krlmlr added some commits Oct 3, 2017

@krlmlr

This comment has been minimized.

Member

krlmlr commented Oct 3, 2017

Yes, of course. Added NEWS.

@hadley hadley merged commit c056eba into master Oct 3, 2017

0 of 4 checks passed

continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment