Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file and line number to test failures and errors in JunitReporter #640

Merged
merged 1 commit into from Oct 12, 2017

Conversation

@nealrichardson
Copy link

@nealrichardson nealrichardson commented Oct 11, 2017

The Junit report doesn't tell you where in the code the failures/errors are, which makes it difficult to track down the source of the problems. This change appends the src_loc(), which some of the other reporters use, to the message.

For what it's worth, TAP and teamcity reporters also appear not to include the source location in their output, and in general it appears that there is not a single standard for expressing this location. I explored a more generic solution as well (master...nealrichardson:format-expectation-failure) but thought it was too disruptive.

@hadley
Copy link
Member

@hadley hadley commented Oct 12, 2017

Thanks - can you please add a bullet to NEWS too?

If you have any PRs in the works, I'm about to re-style testthat to use the tidyverse style which is likely to cause merge conflicts.

Loading

@hadley
Copy link
Member

@hadley hadley commented Oct 12, 2017

Actually let me add the news bullet - I'm about to rewrite the news file too.

Loading

@hadley hadley merged commit 81f9f27 into r-lib:master Oct 12, 2017
1 check failed
Loading
hadley added a commit that referenced this issue Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants