Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two columns to data reurned by list reporter #675

Merged
merged 7 commits into from Apr 1, 2019

Conversation

Projects
None yet
2 participants
@krlmlr
Copy link
Member

commented Nov 11, 2017

  • number of passed tests
  • original results object (in a list column)

New columns added at end, should not disrupt existing code.

Is there any way we could add this to the upcoming release?

@hadley

This comment has been minimized.

Copy link
Member

commented Nov 11, 2017

This seems like a small change but given the number of packages using testthat it does seem possible this could introduce new failures. Could you do a bit of spelunking with github search to see how many packages are using the list reporter?

@krlmlr

This comment has been minimized.

Copy link
Member Author

commented Nov 11, 2017

Difficult to say, because the data is also the return value of testthat::test_dir() etc.. Easier to do a revdep check with downstream packages that import or depend on testthat. Will do.

@krlmlr krlmlr force-pushed the krlmlr:f-list-results branch from 7dc7e41 to cd283c8 Nov 12, 2017

@krlmlr

This comment has been minimized.

Copy link
Member Author

commented Nov 13, 2017

All checks were OK, but it's probably not worth the hassle. We may want to support this in the future, though.

@hadley

This comment has been minimized.

Copy link
Member

commented Mar 31, 2019

I think I'm happy to merge this now if you want to update and add a news bullet.

@krlmlr

This comment has been minimized.

Copy link
Member Author

commented Mar 31, 2019

Done.

@krlmlr krlmlr requested a review from hadley Mar 31, 2019

krlmlr added some commits Mar 31, 2019

@hadley hadley merged commit 9711653 into r-lib:master Apr 1, 2019

3 checks passed

codecov/patch 100% of diff hit (target 82.51%)
Details
codecov/project 82.53% (+0.01%) compared to 8b33b6c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hadley

This comment has been minimized.

Copy link
Member

commented Apr 1, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.