Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two columns to data reurned by list reporter #675

Merged
merged 7 commits into from Apr 1, 2019

Conversation

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Nov 11, 2017

  • number of passed tests
  • original results object (in a list column)

New columns added at end, should not disrupt existing code.

Is there any way we could add this to the upcoming release?

@hadley
Copy link
Member

@hadley hadley commented Nov 11, 2017

This seems like a small change but given the number of packages using testthat it does seem possible this could introduce new failures. Could you do a bit of spelunking with github search to see how many packages are using the list reporter?

Loading

@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Nov 11, 2017

Difficult to say, because the data is also the return value of testthat::test_dir() etc.. Easier to do a revdep check with downstream packages that import or depend on testthat. Will do.

Loading

@krlmlr krlmlr force-pushed the f-list-results branch from 7dc7e41 to cd283c8 Nov 12, 2017
@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Nov 13, 2017

All checks were OK, but it's probably not worth the hassle. We may want to support this in the future, though.

Loading

@hadley
Copy link
Member

@hadley hadley commented Mar 31, 2019

I think I'm happy to merge this now if you want to update and add a news bullet.

Loading

@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Mar 31, 2019

Done.

Loading

@krlmlr krlmlr requested a review from hadley Mar 31, 2019
@hadley hadley merged commit 9711653 into r-lib:master Apr 1, 2019
3 checks passed
Loading
@hadley
Copy link
Member

@hadley hadley commented Apr 1, 2019

Thanks!

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants