Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change object -> act$val in 2 places #771

Merged
merged 4 commits into from
Apr 1, 2019
Merged

change object -> act$val in 2 places #771

merged 4 commits into from
Apr 1, 2019

Conversation

jalsalam
Copy link
Contributor

for #770

@hadley
Copy link
Member

hadley commented Mar 28, 2019

Would you mind adding a small test too?

@jalsalam
Copy link
Contributor Author

jalsalam commented Apr 1, 2019

Added a test (my first edit to a pull request, so hopefully I did it correctly). Thanks!

@hadley
Copy link
Member

hadley commented Apr 1, 2019

Looks perfect - thanks!

@hadley hadley merged commit 475ed3f into r-lib:master Apr 1, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadley hadley Awaiting requested review from hadley

@jimhester jimhester Awaiting requested review from jimhester

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jalsalam @hadley