Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change object -> act$val in 2 places #771

Merged
merged 4 commits into from Apr 1, 2019
Merged

Conversation

@jalsalam
Copy link
Contributor

@jalsalam jalsalam commented Jun 19, 2018

for #770

@jalsalam jalsalam requested review from hadley and jimhester as code owners Jun 19, 2018
@hadley
Copy link
Member

@hadley hadley commented Mar 28, 2019

Would you mind adding a small test too?

Loading

@jalsalam
Copy link
Contributor Author

@jalsalam jalsalam commented Apr 1, 2019

Added a test (my first edit to a pull request, so hopefully I did it correctly). Thanks!

Loading

@hadley
Copy link
Member

@hadley hadley commented Apr 1, 2019

Looks perfect - thanks!

Loading

@hadley hadley merged commit 475ed3f into r-lib:master Apr 1, 2019
1 check was pending
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants