Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve junit time format compatibility #806

Merged
merged 1 commit into from Apr 1, 2019

Conversation

Projects
None yet
2 participants
@comicfans
Copy link
Contributor

commented Oct 16, 2018

Jenkins junit plugin requires time has at most 3 digits, or it reports

junit.xml:cvc-pattern-valid: Value '5.44999999999999' is not facet-valid with respect to pattern '(([0-9]{0,3},)*[0-9]{3}|[0-9]{0,3})*(\.[0-9]{0,3})?' for type 'SUREFIRE_TIME'.
@hadley

This comment has been minimized.

Copy link
Member

commented Mar 31, 2019

Can you please add a bullet to NEWS? It should briefly describe the change and end with (@yourname, #issuenumber).

@comicfans comicfans force-pushed the comicfans:improve_junit_time_compatibility branch from 92e747d to 664de37 Apr 1, 2019

Improve junit time format compatibility
Jenkins junit requires time has at most 3 digits

@comicfans comicfans force-pushed the comicfans:improve_junit_time_compatibility branch from 664de37 to 95687d9 Apr 1, 2019

@comicfans

This comment has been minimized.

Copy link
Contributor Author

commented Apr 1, 2019

of course , but I found bullet is written as (#issuenumber, @username) so I followed this style

@hadley hadley merged commit e703dba into r-lib:master Apr 1, 2019

3 checks passed

codecov/patch 100% of diff hit (target 82.51%)
Details
codecov/project 82.51% (+0%) compared to 8b33b6c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hadley

This comment has been minimized.

Copy link
Member

commented Apr 1, 2019

Thanks, although in the future please follow the new bullet style that I requested, not the old.

@comicfans comicfans deleted the comicfans:improve_junit_time_compatibility branch Apr 1, 2019

@comicfans

This comment has been minimized.

Copy link
Contributor Author

commented Apr 1, 2019

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.