Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matches() should optionally use stringr #238

Closed
hadley opened this issue May 4, 2021 · 0 comments · Fixed by #275
Closed

matches() should optionally use stringr #238

hadley opened this issue May 4, 2021 · 0 comments · Fixed by #275
Assignees
@hadley
Labels
feature a feature request or enhancement helpers

Comments

@hadley
Copy link
Member

hadley commented May 4, 2021 •
edited
Loading

If match has class pattern (which I should probably change to stringr_pattern, tidyverse/stringr#384)

(Low priority, but will make matches() a bit more consistent with the general direction in which we're going)
@lionel- lionel- added feature a feature request or enhancement helpers labels Mar 3, 2022
@hadley hadley mentioned this issue Aug 10, 2022
Merged
hadley added a commit that referenced this issue Aug 11, 2022
@hadley
Detect stringr pattern in matches() (#275)
c19b04d 
Fixes #238
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hadley hadley

Labels
feature a feature request or enhancement helpers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Detect stringr pattern in matches() r-lib/tidyselect
2 participants
@hadley @lionel-